Implement a multi lane atomic for assertion counts #453
+208
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can speed up assertions in highly parallel tests by a factor of 3 and more, with a slight slowdown for the single threaded case. Adds the configuration option `DOCTEST_CONFIG_NO_MULTI_LANE_ATOMICS` to disable multi lane atomics.
|
LGTM! Thanks for the PR :) |
|
Thanks, and happy new year! |
onqtam
pushed a commit
that referenced
this pull request
Feb 2, 2021
Adds the configuration option `DOCTEST_CONFIG_NO_MULTI_LANE_ATOMICS` to disable multi lane atomics. This can speed up assertions in highly parallel tests by a factor of 3 and more, with a slight slowdown for the single threaded case. Closes #452
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can speed up assertions in highly parallel tests by a factor of 3 and more, with a slight slowdown for the single threaded case.
Adds the configuration option
DOCTEST_CONFIG_NO_MULTI_LANE_ATOMICSto disable multi lane atomics.See #452
Compiled & ran
ctesttests with g++4.8 and g++10.2. I couldn't compile with clang++ because lots of unrelated other warnings-as-errors.