Correct DOCTEST_NO_INSTALL logic; do install unless it is set #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Commit b63bf85 (fixing #96) introduces the
DOCTEST_NO_INSTALL
variable, but it's use is reversed: by default it is set toOFF
(meaning you do want to install), but the test says "If set to ON, do install".This made me upload a
doctest.h
-lessdoctest-dev
package to Debian.Debian bug
This was detected through a failed build of
argagg
and reported as https://bugs.debian.org/880721 .