-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Page number doesn't change #17
Comments
Page numbers are tricky, because the number of commits in the repositories can change out underneath us. Our best idea is to always show what page number we think you're on, which will possibly jump around if someone pushes a bunch of commits while you're paging. |
It's on my todo list to fix the number incrementing -- it appears to be a regression that occurred over the past week or so. As to the total page count -- short answer is no. We don't want to do a (potentially massive) commit count just to get that number. We need to keep the paging as efficient as possible. |
This appears to have been fixed at some point before the writing of this comment (that is, at some point before e8e2070). I can only reproduce this for the known corner cases, such as when there are many commits with the same timestamp. Sid, please try your saved searches again after we redeploy Barkeep (we'll send an email) and update this ticket to let us know if any/all of your saved searches are still exhibiting this behavior. |
31b21a1 should fix this. It should look more correct, although it's even more of a guess now :) |
Scroll right on a saved search - the page number remains 1.
Is it possible to have a count of the total number of pages? Page 1/5 rather than just Page 1.
The text was updated successfully, but these errors were encountered: