Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a keyboard shortcut to "approve commit" #25

Closed
philc opened this issue Sep 2, 2011 · 1 comment
Closed

Add a keyboard shortcut to "approve commit" #25

philc opened this issue Sep 2, 2011 · 1 comment
Assignees
@cespare
Labels
feature request
Milestone
0.2.0 Release

Comments

@philc
Copy link
Contributor

philc commented Sep 2, 2011

The main difficulty is to show them some UX to verify that the commit has been approved -- maybe scrolling to the button, or sliding up a message from the button of the window saying "approved" ala Vimium.

Hitting this key twice should not toggle it again from approved to unapproved.
@philc
Copy link
Contributor Author

philc commented Sep 15, 2011

This is the only thing preventing me from being entirely mouseless. Grr.

@ghost ghost assigned cespare Sep 30, 2011
@cespare cespare closed this as completed in 34393e2 Oct 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cespare cespare

Labels
feature request
Projects
None yet
Milestone
0.2.0 Release
Development

No branches or pull requests
2 participants
@philc @cespare