Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged commits bypass email preferences #495

Open
cespare opened this issue Jul 8, 2014 · 0 comments
Open

Merged commits bypass email preferences #495

cespare opened this issue Jul 8, 2014 · 0 comments
Labels

Comments

@cespare
Copy link
Contributor

cespare commented Jul 8, 2014

Discovered an interesting bug/consequence-of-the-data-model today. Say you have a saved search for 'repos: foo' (implicitly this only covers the master branch). Then you make commit c1 to the branch B. When barkeep picks up this commit, it checks to see who has a saved search that includes c1 (probably nobody, unless someone is watching branch B or 'branches: all'). Then if you later merge c1 to master, it's not a new commit and so no email is ever sent.

@cespare cespare added the bug label Jul 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant