Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit wide comments does not update after submit or delete is clicked. #56

Closed
bo-chen opened this issue Sep 15, 2011 · 1 comment
Closed
Labels

Comments

@bo-chen
Copy link
Contributor

bo-chen commented Sep 15, 2011

The UI doesn't update from the form to the comment div. The comments do get sent to the server, but user doesn't get the feedback. So the user will probably spam the submit button a few more times before giving up.

@cespare
Copy link
Contributor

cespare commented Sep 16, 2011

Looks like during the changes for side-by-side, you had to alter both of the comments whenever there were changes like submit or delete, and the way you're looking them up is broken for commit-level comments. For example, line 171 of commit.coffee:

form = $(e.currentTarget).parents(".file").find(".commentForm[form-id='" + formId + "']")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants