Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureGenerators: Support normalisation alongside categorical features that are not encoded #85

Open
opcode81 opened this issue Feb 27, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@opcode81
Copy link
Owner

Right now, we cannot deal with this when using categorical default rules, as they will render the categorical features unsupported rather than ignored.

While I am not aware of models that benefit from both unencoded categorical features and normalisation, we could still consider adding this, especially since users users are likely to apply unnecessary normalisation to, for example, tree-based models.

Proposal:

  • make add_categorical_default_rules accept not only bool but also an enum CategoricalRule with items UNSUPPORTED, IGNORED, NONE.
  • handle it appropriately
  • pass add_categorical_rules through to further subclasses, in particular TakeColumns.

@schroedk FYI

@opcode81 opcode81 added the enhancement New feature or request label Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant