Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add VDMS retriever microservice for v0.9 Milestone #539

Merged

Conversation

s-gobriel
Copy link
Contributor

Description

Add VDMS retriever component. Targeting v0.9 milestone. Retriever is part of a megaservice for video QA RAG system.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

  • [X ] New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

new test script added to test folder. test-retrievers_langchain_vdms.sh

@s-gobriel
Copy link
Contributor Author

@chensuyue can you please tag this PR with v0.9 milestone

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
comps/cores/proto/docarray.py 99.12% <100.00%> (+<0.01%) ⬆️

@chensuyue chensuyue added this to the v0.9 milestone Aug 21, 2024
@BaoHuiling
Copy link
Collaborator

@XuhuiRen @lvliang-intel Could you help to review the code? Thanks

@chensuyue chensuyue modified the milestones: v0.9, v1.0 Aug 27, 2024
@BaoHuiling BaoHuiling mentioned this pull request Aug 29, 2024
3 tasks
@lvliang-intel
Copy link
Collaborator

@s-gobriel
Please resolve the conflicts and fix example test issue.

@XuhuiRen

This comment was marked as off-topic.

@BaoHuiling
Copy link
Collaborator

@s-gobriel please see #538 (comment) to fix the CI test.

Signed-off-by: BaoHuiling <[email protected]>
@BaoHuiling
Copy link
Collaborator

does this VDMS need extra operation to index the data? It seems that this retriever is rely on VDMS vectorstore, plz add the corresponding data indexing code under "dataprep" folder. In this way, the user can get a convenient way to use this retriever and vectorstore.

Hi Xuhui, Sameh is OoO since US holiday today. @srinarayan-srikanthan is planning to raise another PR for dataprep for VDMS, on ww36'4 (ww36'3 in US).

@BaoHuiling
Copy link
Collaborator

@s-gobriel, Please resolve the conflicts and fix example test issue.

Hi liang, the conflict and example test is good now

@ttrigui
Copy link

ttrigui commented Sep 3, 2024

@lvliang-intel , can we please merge this PR since all issues are resolved?

@lvliang-intel lvliang-intel merged commit 445c9b1 into opea-project:main Sep 4, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants