Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics files are not dumped if enabling "service-metric-collect" when using benchmark.py #102

Closed
joshuayao opened this issue Sep 4, 2024 · 1 comment

Comments

@joshuayao
Copy link
Collaborator

joshuayao commented Sep 4, 2024

stresscli.py requires service-list if set service-metric-collect=true in profile yaml to collect and dump metrics. But benchmark.py does not provide an approach to provide 'service-list' (see below).

def create_run_yaml_content(service_name, base_url, bench_target, concurrency, user_queries, test_suite_config):
    """Create content for the run.yaml file."""
    return {
        "profile": {
            "storage": {"hostpath": test_suite_config["test_output_dir"]},
            "global-settings": {
                "tool": "locust",
                "locustfile": os.path.join(os.getcwd(), "stresscli/locust/aistress.py"),
                "host": base_url,
                "stop-timeout": 120,
                "processes": 2,
                "namespace": "default",
                "bench-target": bench_target,
                "run-time": test_suite_config["run_time"],
                "service-metric-collect": test_suite_config["collect_service_metric"],
                "llm-model": test_suite_config["llm_model"],
                "deployment-type": test_suite_config["deployment_type"],
            },
            "runs": [{"name": "benchmark", "users": concurrency, "max-request": user_queries}],
        }
    }
@joshuayao
Copy link
Collaborator Author

Fixed by #105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant