add bench-target as the prefix of output folder #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yingchun Guo <[email protected]>
lkk12014402
pushed a commit
that referenced
this pull request
Sep 19, 2024
Signed-off-by: letonghan <[email protected]>
gavinlichn
approved these changes
Sep 19, 2024
lvliang-intel
approved these changes
Sep 19, 2024
adkakne
pushed a commit
to adkakne/GenAIEval
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Yingchun Guo <[email protected]> Signed-off-by: aasavari <[email protected]>
adkakne
pushed a commit
to adkakne/GenAIEval
that referenced
this pull request
Sep 20, 2024
Signed-off-by: Yingchun Guo <[email protected]> Signed-off-by: aasavari <[email protected]>
XinyuYe-Intel
pushed a commit
that referenced
this pull request
Sep 24, 2024
* minimized required fields/columns in user data Signed-off-by: aasavari <[email protected]> * add bench-target as the prefix of output folder (#133) Signed-off-by: Yingchun Guo <[email protected]> Signed-off-by: aasavari <[email protected]> * remove examples. (#135) Co-authored-by: root <[email protected]> Signed-off-by: aasavari <[email protected]> * minor naming correction to maintain consistency Signed-off-by: aasavari <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: aasavari <[email protected]> * Add hyperlinks and paths validation. (#132) Signed-off-by: ZePan110 <[email protected]> Signed-off-by: aasavari <[email protected]> * added support for older version of ragas Signed-off-by: aasavari <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: aasavari <[email protected]> Signed-off-by: Yingchun Guo <[email protected]> Signed-off-by: ZePan110 <[email protected]> Co-authored-by: Ying Chun Guo <[email protected]> Co-authored-by: lkk <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ZePan110 <[email protected]>
lvliang-intel
pushed a commit
that referenced
this pull request
Sep 24, 2024
* minimized required fields/columns in user data Signed-off-by: aasavari <[email protected]> * add bench-target as the prefix of output folder (#133) Signed-off-by: Yingchun Guo <[email protected]> Signed-off-by: aasavari <[email protected]> * remove examples. (#135) Co-authored-by: root <[email protected]> Signed-off-by: aasavari <[email protected]> * minor naming correction to maintain consistency Signed-off-by: aasavari <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Signed-off-by: aasavari <[email protected]> * Add hyperlinks and paths validation. (#132) Signed-off-by: ZePan110 <[email protected]> Signed-off-by: aasavari <[email protected]> * adding README for OPEA ragas Signed-off-by: aasavari <[email protected]> * adding python3 syntax to README Signed-off-by: aasavari <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: aasavari <[email protected]> Signed-off-by: Yingchun Guo <[email protected]> Signed-off-by: ZePan110 <[email protected]> Co-authored-by: Ying Chun Guo <[email protected]> Co-authored-by: lkk <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: ZePan110 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add bench-target as the prefix of output folder, in order to easily understand the test case of the output
Issues
Currently, all output folders are in timestamp format. When testing with multiple endpoints, it's very hard to understand which test cases output folder is. Adding the bench-target can easily separate different test cases.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a
Tests
n/a