Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Session History Feature for the Video RAG Chat Interface #253

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Conversation

bashirmoham
Copy link

Description

This pull request adds a session history feature to the get_formatted_prompt function. The changes include updating the function to accept and utilize the history parameter, ensuring that the user's previous chat history is incorporated into the prompt formatting process.

Changes Made

  • Added get_history function to retrieve the last three messages from the session state
  • Added the history parameter to the get_formatted_prompt function signature.
  • Assigned the history variable within the template rendering process to maintain correct scope and functionality.
  • Included placeholders for scene description, user's previous chat history, and user's question.
  • Added rules for the assistant to follow while answering questions based on the provided scene description and history.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Tested and now showing the history.

@bashirmoham bashirmoham changed the title Add Session History Feature for the Video RAG Chat Interface #1 Add Session History Feature for the Video RAG Chat Interface Jun 4, 2024
@lvliang-intel
Copy link
Collaborator

@bashirmoham,

could you please fix the pre-commit issues?

image

@lvliang-intel
Copy link
Collaborator

and also code scan issue:

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All microservice-related code should be placed in the GenAIComps repo. Only the Docker Compose files, Kubernetes manifests, and UI code need to be stored in the GenAIExamples repo. Please reorganize your code accordingly. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants