E2E: exclude terminating pods when wait_util_all_pod_ready #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: KfreeZ <[email protected]>
Signed-off-by: KfreeZ <[email protected]>
lianhao
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When wait_util_all_pod_ready is executed and there are pods being deleted, the wait_util_all_pod_ready count all the pods including Terminating pods and wait them to be ready, which could never happen.
Solution: exclude the terminating pods when collecting the pods names.
Issues
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
n/a.Tests
covered by CI/CD