Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e helm chart: Add ui for codegen/codetrans/docsum #415

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

lianhao
Copy link
Collaborator

@lianhao lianhao commented Sep 9, 2024

Description

e2e helm chart: Add ui for codegen/codetrans/docsum.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • New feature (non-breaking change which adds new functionality)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Copy link
Collaborator

@Ruoyu-y Ruoyu-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But the chatqna-ui helm chart is used as a common chart for all UI installation, correct? If that's the case, shall we rename it to something else?

@lianhao
Copy link
Collaborator Author

lianhao commented Sep 10, 2024

LGTM. But the chatqna-ui helm chart is used as a common chart for all UI installation, correct? If that's the case, shall we rename it to something else?

agreed. Let me rename it to ui.

@lianhao lianhao merged commit 267d828 into opea-project:main Sep 10, 2024
21 checks passed
@lianhao lianhao deleted the codetrans_ui branch September 10, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants