Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows fixes and removal of $SHELL #91

Closed
wants to merge 2 commits into from
Closed

Windows fixes and removal of $SHELL #91

wants to merge 2 commits into from

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Nov 5, 2019 •
edited
Loading

This is my WIP branch. It does work but there are a few things I'm not sure about

  1. running tests leaves open handles behind; you can see this on GitHub Actions in the cleaning up step:

    Cleaning up orphan processes
    Terminate orphan process: pid (1224) (node)
    Terminate orphan process: pid (6808) (node)

  2. I switched to shell: true; this might have other implications we need to test
  3. I had to set DEBUG_TESTS = true otherwise tests didn't pass on Windows; would be nice to find the root cause
  4. We need to verify if we need Add escape-string-regexp #88 or not

Fixes #84, fixes #62, fixes #61

@sbleon sbleon mentioned this pull request Nov 6, 2019
Open
@XhmikosR
Copy link
Contributor Author

@paulmillr how do you want to proceed with this?

@XhmikosR XhmikosR closed this Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@XhmikosR