Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group validation errors by oneOf subschema #124

Open
Bjwebb opened this issue Oct 2, 2019 · 3 comments
Open

Group validation errors by oneOf subschema #124

Bjwebb opened this issue Oct 2, 2019 · 3 comments
Labels
check results Relating to how specific checks are reported

Comments

@Bjwebb
Copy link
Contributor

Bjwebb commented Oct 2, 2019

In OpenDataServices/cove#895 we now assume whether a record has linked or embedded releases, in order to use the correct subschema within the oneOf block. Text about this assumption is added to every relevant validation message.

This text is repeated for each validation error message. Instead we should group the messages by subschema used, and state the assumption only once.

@robredpath robredpath transferred this issue from OpenDataServices/cove Oct 14, 2020
@robredpath robredpath transferred this issue from another repository Oct 14, 2020
@jpmckinney jpmckinney added the check results Relating to how specific checks are reported label Oct 14, 2020
@jpmckinney
Copy link
Member

Possible related: #126

@duncandewhurst
Copy link
Contributor

duncandewhurst commented Aug 25, 2021

Unlike #126, which only affects records with a mix of embedded and linked release, this issue affects any record with issues in its releases array.

@duncandewhurst
Copy link
Contributor

Here's an example of some data that triggers the addition of the text to several errors: https://gist.github.com/duncandewhurst/b15299d96b97304c87cb16a8b201c3e6

I find the way it is reported currently quite confusing when the validation message is about an object other than the release, e.g.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check results Relating to how specific checks are reported
Projects
None yet
Development

No branches or pull requests

3 participants