Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use consistent id param type in private.ts #125

Open
jpmckinney opened this issue Aug 21, 2024 · 0 comments
Open

Use consistent id param type in private.ts #125

jpmckinney opened this issue Aug 21, 2024 · 0 comments
Labels

Comments

@jpmckinney
Copy link
Member

4 times it's id: number, 4 times it's id: string. It'd be better to be consistent, to avoid accidental errors.

When it's number, the caller does e.g. downloadDocumentFn(Number(id)), except for applicationStartFn, which I guess casts as number using useMutation (the others use useQuery).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant