Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Type: Add boolean and time, remove long and double #30

Open
jpmckinney opened this issue Apr 2, 2024 · 0 comments
Open

Data Type: Add boolean and time, remove long and double #30

jpmckinney opened this issue Apr 2, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jpmckinney
Copy link
Member

time is relevant, as some data sources split date and time as different elements.

Also, I'm not sure why we have long and double, since they are just different length integer and real numbers. (Databases have many more numeric types that aren't listed: smallint, bigint, serial, etc.)

Decimal (also "numeric") is also a distinct type. It's more precise than float (which can have floating-point errors). Not sure if we care about retaining that distinction.

Note that different contexts use different words. Not sure which context makes the most sense. Current choice in bold.

  • character (ANSI SQL); char, varchar, text (non-standard SQL); string (JSON)
  • enum (non-standard SQL); codelist (OCDS)
  • float, real (ANSI SQL); number (JSON)
  • timestamp (ANSI SQL); datetime (non-standard SQL); date-time (JSON Schema)

These don't have such issues:

  • boolean
  • date
  • time
  • integer
@jpmckinney jpmckinney added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant