You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Vue seems to have bugs that are difficult to resolve:
Eliminates whitespaces, requiring . Some components seem to preserve whitespace; others don't. Fix whitespace removal #106
Makes it challenging to respect browser behavior (e.g. cmd-click to open link in new tab). In listings, the @click on the div can be removed, and a b-link with :to can be added, but this also reduces the size of the target from the full row to the text. It's possible that switching to b-table instead of divs and using row-clicked is the correct solution. We might also just add some non-Vue JS like in the data-registry to add a larger clickable. Previously, Datlab had overridden the context menu (!), but this means the browser's context menu is inaccessible. Allow Ctrl-Click / Cmd-Click to work to open new tabs on table rows #105
Also, the way Vue is implemented...
It sends multiple HTTP requests per page. Whatever gains were made by not reloading the full page are lost by making additional requests. Only on the overview page, and mostly to pre-load the next pages.
There is a ton of repeated CSS across components. While component-specific CSS is meant to reduce payload, the implementation ends up increasing it. We can tidy this up.
Hyperlinks are often missing. I fixed those on the landing page Hyperlinks need to be visible to users #35, but this should be corrected in all tables. However, this runs into the challenges in the second bullet above.
Another note: the JSON API is actually quite simple and well designed (especially after the #74 refactor), unlike some other SPAs, where the JSON API is a mess withno design other than "the frontend needs this data".
Vue seems to have bugs that are difficult to resolve:
Eliminates whitespaces, requiring
. Some components seem to preserve whitespace; others don't. Fix whitespace removal #106@click
on thediv
can be removed, and ab-link
with:to
can be added, but this also reduces the size of the target from the full row to the text. It's possible that switching to b-table instead of divs and usingrow-clicked
is the correct solution. We might also just add some non-Vue JS like in the data-registry to add a larger clickable. Previously, Datlab had overridden the context menu (!), but this means the browser's context menu is inaccessible. Allow Ctrl-Click / Cmd-Click to work to open new tabs on table rows #105Also, the way Vue is implemented...
It sends multiple HTTP requests per page. Whatever gains were made by not reloading the full page are lost by making additional requests.Only on the overview page, and mostly to pre-load the next pages.There is a ton of repeated CSS across components. While component-specific CSS is meant to reduce payload, the implementation ends up increasing it.We can tidy this up.It also has some weird things that are officially documented, like how disabled b-links look the same as regular links, and additional CSS is required to fix it.
Off the top of my head, the only real needs for JS are:
If we remove Vue (not a small task), we might not need much of an API, and therefore resolve:
Besides #105 and #106 above, we can also skip:
#104 also becomes easier, as we just use Django's translation framework.
The text was updated successfully, but these errors were encountered: