Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: Option to group field check results thematically #37

Open
duncandewhurst opened this issue Mar 9, 2020 · 6 comments
Open

List: Option to group field check results thematically #37

duncandewhurst opened this issue Mar 9, 2020 · 6 comments
Labels
field checks Relating to field-level check pages
Milestone

Comments

@duncandewhurst
Copy link

For example, in the Data Feedback Notebook there is a check for unlikely dates which checks the .startDate and .endDate fields in tender.tenderPeriod, tender.enquiryPeriod, tender.awardPeriod and tender.contractPeriod.

In Pelican the same check is split across 8 different individual checks.

When sharing feedback with publishers it would be useful to group results where the same check is applied across different fields, e.g. summary of all checks for non-negative numbers, summary of all checks for realistic dates etc.

@jpmckinney
Copy link
Member

Are you thinking this might be a view you toggle into? For example, there's currently a toggle at the top-right of the field table to nest fields or not.

@duncandewhurst
Copy link
Author

Yep, a toggle for group by field / group by check type sounds good.

@jpmckinney
Copy link
Member

@duncandewhurst Could you describe the groups you would want? Once we have that, we can plan the changes.

@duncandewhurst
Copy link
Author

The main one I had in mind was to group all the 'Date is realistic' checks in one place.

But it would be helpful to group any other checks which are applied to multiple fields, e.g. 'Document type is coherent' and 'Has 250 characters or less'.

I picked those examples by looking at the check results for the latest Moldova collection, but there could be others depending on which fields are included in a collection. Is there a full list of checks I can review somewhere?

@jpmckinney
Copy link
Member

Here's a list of checks that I exported from Pelican. I can reformat the output as a spreadsheet with more detail on field paths for field-level checks. Let me know if you prefer that.

In most cases, for now, you can sort by quality and use the filter text box to search for "document" or "period", and the matching checks will be at the top of the list.

In any case, for field-level checks, I think it should be fairly straight forward to group by check type (Document type is coherent, etc.).

@duncandewhurst
Copy link
Author

Thanks!

From that list, I think 'Document format is recognized' and 'Number is non-negative' are the other useful ones to group by.

@jpmckinney jpmckinney transferred this issue from open-contracting-archive/pelican Sep 14, 2021
@jpmckinney jpmckinney added the field checks Relating to field-level check pages label Sep 14, 2021
@jpmckinney jpmckinney changed the title Consider grouping field check results Option to group field check results thematically Sep 14, 2021
@jpmckinney jpmckinney added this to the Priority milestone Dec 1, 2021
@jpmckinney jpmckinney changed the title Option to group field check results thematically List: Option to group field check results thematically Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
field checks Relating to field-level check pages
Projects
None yet
Development

No branches or pull requests

2 participants