-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge the pagination extension #1327
Comments
@jpmckinney - I'm assuming we want to treat the following content from the extension's readme as non-normative guidance and move it to https://standard.open-contracting.org/staging/1.2-dev/en/guidance/build/hosting/. Is there anything else to discuss before preparing a PR?
|
Since the fields are new and optional, we can make normative statements about them. However, if we are reducing the role of packages (#920), it might not make sense to merge an extension that adds fields to packages. There are many ways to paginate without next/prev links in the data (e.g. GitHub uses HTTP headers, to separate API metadata from data/content): https://docs.github.com/en/rest/guides/traversing-with-pagination So, I think this issue requires more discussion on whether to go ahead or not. |
Hmm. I thought that in #1084 we settled on keeping packages as the 'API format', for which pagination is relevant. That said, I think it's fine to keep pagination as an extension. Regarding different approaches to pagination, it's easier for aggregators or other users that want to work with OCDS data from multiple publishers if OCDS APIs use a consistent approach. In that respect, it's useful to recommend an approach to encourage standardisation. Recommending an approach also gives a sensible 'default' for implementers who might not know the pros and cons of different options. Of course, if implementers have a preference/use case/reason for using a different approach, they can. I don't have a particular preference for one approach over another. If I remember correctly, we decided on the links approach based on desk research and community calls. @kindly might have a view on this. |
Links are certainly the easiest to implement and use, since some users don't even know about HTTP headers. Since we need to keep packages for 1.x anyway, we might as well add pagination as implemented in the extension. Rather than a guidance page, add a page for APIs under the Reference section (maybe "API responses"). As part of #1084, we can move the release/record package schema pages under that, to keep the Reference section somewhat organized. |
Noting that since pagination content was added to the guidance for #1095, we might as well just link to it there, were it appears in context without other content that is more purely guidance. |
Creating a new issue for this comment from #928 since the main topic of that issue will be addressed separately:
Originally posted by @jpmckinney in #928 (comment)
The text was updated successfully, but these errors were encountered: