Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all (most?) dependency versions out of Common.prod.props? #147

Open
toddbaert opened this issue Jan 25, 2024 · 1 comment
Open

Move all (most?) dependency versions out of Common.prod.props? #147

toddbaert opened this issue Jan 25, 2024 · 1 comment
Assignees
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

Since this is a monorepo to support various contributions (providers, hooks, framework-specific integrations) we should try to decentralize dependency management as much as possible (move dependencies into the subfolder belonging to the associated module). This is especially important to make optimal use of both release-please and the component_owners configuration. The OpenFeature SDK dependency as well as any module-specific dependencies should be maintained by each module. Some basic common modules and test modules may be centrally maintained if that's valuable.

See: #136 (review), #136 (comment)

Originally posted by @austindrenski in #136 (comment)

@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 25, 2024
@toddbaert toddbaert added the contribfest A good issue for Contribfest KubeCon EU '24 label Mar 11, 2024
@jenshenneberg
Copy link
Contributor

I had a quick look at this and am happy to give it a go. What I can see needs to be done is:

  • Remove this line and add the reference directly to the individual projects
  • (Optional) Rework this section to potentially push some test dependencies down to individual projects, and to reference the version directly in the rest, so renovate can do it's work on updating them.

@jenshenneberg jenshenneberg self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribfest A good issue for Contribfest KubeCon EU '24 good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants