feat: add custom jsonLogic string evaluators #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
toddbaert
reviewed
Feb 20, 2024
Comment on lines
+53
to
+60
| var targetingString = @"{""ends_with"": [ | ||
| { | ||
| ""var"": [ | ||
| ""color"" | ||
| ] | ||
| }, | ||
| ""purple"" | ||
| ]}"; |
There was a problem hiding this comment.
Multi-line strings work great for this. The equivalent tests are so ugly in Java.
toddbaert
approved these changes
Feb 20, 2024
toddbaert
reviewed
Feb 20, 2024
toddbaert
approved these changes
Feb 20, 2024
There was a problem hiding this comment.
This looks good, I have one small question, but pre-approving: https://github.com/open-feature/dotnet-sdk-contrib/pull/158/files#r1496412190
Signed-off-by: Florian Bacher <[email protected]>
…/open-feature/dotnet-sdk-contrib into feat/jsonlogic-string-comparison
toddbaert
approved these changes
Feb 21, 2024
This was referenced Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #139
This PR adds the
starts_withandends_withcustom JsonLogic evaluators