From f0f9518d8d682f61962644b57b41795c2c64a235 Mon Sep 17 00:00:00 2001 From: Skye Gill Date: Fri, 24 Feb 2023 16:50:54 +0000 Subject: [PATCH 1/2] feat: increase sleep in caching tests from 250ms to 500ms Signed-off-by: Skye Gill --- features/caching.feature | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/features/caching.feature b/features/caching.feature index bfaaf4b..bfe4a36 100644 --- a/features/caching.feature +++ b/features/caching.feature @@ -36,7 +36,7 @@ Feature: Flag caching Given a boolean flag with key "boolean-flag" is evaluated with details and default value "false" And a boolean flag with key "boolean-flag-copy" is evaluated with details and default value "false" When the flag's configuration with key "boolean-flag" is updated to defaultVariant "off" - And sleep for 250 milliseconds + And sleep for 500 milliseconds And a boolean flag with key "boolean-flag" is evaluated with details and default value "false" And a boolean flag with key "boolean-flag-copy" is evaluated with details and default value "false" Then the resolved boolean details reason of flag with key "boolean-flag" should be "STATIC" @@ -46,7 +46,7 @@ Feature: Flag caching Given a string flag with key "string-flag" is evaluated with details and default value "bye" And a string flag with key "string-flag-copy" is evaluated with details and default value "bye" When the flag's configuration with key "string-flag" is updated to defaultVariant "parting" - And sleep for 250 milliseconds + And sleep for 500 milliseconds And a string flag with key "string-flag" is evaluated with details and default value "bye" And a string flag with key "string-flag-copy" is evaluated with details and default value "bye" Then the resolved string details reason of flag with key "string-flag" should be "STATIC" @@ -56,7 +56,7 @@ Feature: Flag caching Given an integer flag with key "integer-flag" is evaluated with details and default value 1 And an integer flag with key "integer-flag-copy" is evaluated with details and default value 1 When the flag's configuration with key "integer-flag" is updated to defaultVariant "one" - And sleep for 250 milliseconds + And sleep for 500 milliseconds And an integer flag with key "integer-flag" is evaluated with details and default value 1 And an integer flag with key "integer-flag-copy" is evaluated with details and default value 1 Then the resolved integer details reason of flag with key "integer-flag" should be "STATIC" @@ -66,7 +66,7 @@ Feature: Flag caching Given a float flag with key "float-flag" is evaluated with details and default value 0.1 And a float flag with key "float-flag-copy" is evaluated with details and default value 0.1 When the flag's configuration with key "float-flag" is updated to defaultVariant "tenth" - And sleep for 250 milliseconds + And sleep for 500 milliseconds And a float flag with key "float-flag" is evaluated with details and default value 0.1 And a float flag with key "float-flag-copy" is evaluated with details and default value 0.1 Then the resolved float details reason of flag with key "float-flag" should be "STATIC" @@ -76,7 +76,7 @@ Feature: Flag caching Given an object flag with key "object-flag" is evaluated with details and a null default value And an object flag with key "object-flag-copy" is evaluated with details and a null default value When the flag's configuration with key "object-flag" is updated to defaultVariant "empty" - And sleep for 250 milliseconds + And sleep for 500 milliseconds And an object flag with key "object-flag" is evaluated with details and a null default value And an object flag with key "object-flag-copy" is evaluated with details and a null default value Then the resolved object details reason of flag with key "object-flag" should be "STATIC" From 66acd7612b0dfc0c682317225edc2bded365352f Mon Sep 17 00:00:00 2001 From: Skye Gill Date: Fri, 24 Feb 2023 16:53:24 +0000 Subject: [PATCH 2/2] feat: increase sleep in caching tests from 500ms to 1000ms Signed-off-by: Skye Gill --- features/caching.feature | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/features/caching.feature b/features/caching.feature index bfe4a36..6be9205 100644 --- a/features/caching.feature +++ b/features/caching.feature @@ -36,7 +36,7 @@ Feature: Flag caching Given a boolean flag with key "boolean-flag" is evaluated with details and default value "false" And a boolean flag with key "boolean-flag-copy" is evaluated with details and default value "false" When the flag's configuration with key "boolean-flag" is updated to defaultVariant "off" - And sleep for 500 milliseconds + And sleep for 1000 milliseconds And a boolean flag with key "boolean-flag" is evaluated with details and default value "false" And a boolean flag with key "boolean-flag-copy" is evaluated with details and default value "false" Then the resolved boolean details reason of flag with key "boolean-flag" should be "STATIC" @@ -46,7 +46,7 @@ Feature: Flag caching Given a string flag with key "string-flag" is evaluated with details and default value "bye" And a string flag with key "string-flag-copy" is evaluated with details and default value "bye" When the flag's configuration with key "string-flag" is updated to defaultVariant "parting" - And sleep for 500 milliseconds + And sleep for 1000 milliseconds And a string flag with key "string-flag" is evaluated with details and default value "bye" And a string flag with key "string-flag-copy" is evaluated with details and default value "bye" Then the resolved string details reason of flag with key "string-flag" should be "STATIC" @@ -56,7 +56,7 @@ Feature: Flag caching Given an integer flag with key "integer-flag" is evaluated with details and default value 1 And an integer flag with key "integer-flag-copy" is evaluated with details and default value 1 When the flag's configuration with key "integer-flag" is updated to defaultVariant "one" - And sleep for 500 milliseconds + And sleep for 1000 milliseconds And an integer flag with key "integer-flag" is evaluated with details and default value 1 And an integer flag with key "integer-flag-copy" is evaluated with details and default value 1 Then the resolved integer details reason of flag with key "integer-flag" should be "STATIC" @@ -66,7 +66,7 @@ Feature: Flag caching Given a float flag with key "float-flag" is evaluated with details and default value 0.1 And a float flag with key "float-flag-copy" is evaluated with details and default value 0.1 When the flag's configuration with key "float-flag" is updated to defaultVariant "tenth" - And sleep for 500 milliseconds + And sleep for 1000 milliseconds And a float flag with key "float-flag" is evaluated with details and default value 0.1 And a float flag with key "float-flag-copy" is evaluated with details and default value 0.1 Then the resolved float details reason of flag with key "float-flag" should be "STATIC" @@ -76,7 +76,7 @@ Feature: Flag caching Given an object flag with key "object-flag" is evaluated with details and a null default value And an object flag with key "object-flag-copy" is evaluated with details and a null default value When the flag's configuration with key "object-flag" is updated to defaultVariant "empty" - And sleep for 500 milliseconds + And sleep for 1000 milliseconds And an object flag with key "object-flag" is evaluated with details and a null default value And an object flag with key "object-flag-copy" is evaluated with details and a null default value Then the resolved object details reason of flag with key "object-flag" should be "STATIC"