Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Launch darkly provider fixes #444

Closed
sago2k8 opened this issue Jul 4, 2023 · 4 comments
Closed

Launch darkly provider fixes #444

sago2k8 opened this issue Jul 4, 2023 · 4 comments
Assignees

Comments

@sago2k8
Copy link
Contributor

sago2k8 commented Jul 4, 2023

Hello everybody, don't really know if this is the correct process but we want to get launch darkly working for our frontend use case.

problem:

There is a provider but there are couple of issues:

  • the initialization proposed is outside the Provider which makes it hard to integrate and error prone.
  • The library includes imports from @openfeature/js-sdk for types, prefered in this case should be @openfeature/web-sdk
  • The provider seems to now work due the external initialisation, it seem to never get ready.

I opened a PR #418 that handles this issues, it has been tested in one of our frontend applications, the motivation for this change is basically to get the ball rolling and use the provider.

@toddbaert
Copy link
Member

@sago2k8 Thanks for much for creating this issue.

As you've probably noticed, our web-sdk is still considered experimental. However, we are hoping to release a beta, and shortly after a 1.0 release soon (on the timescale of weeks, ideally). We did recently merged a fix for the SDK which could result in missing events in certain situations (see here) but the case is pretty narrow so I doubt it impacts you.

Regardless, I don't think the current implementation of the LD client provider supports some of the newer SDK features (events), and I suspect your PR brings significant value. Work like this will definitely help us move toward a confident 1.0 release!

I will review your PR today.

@sago2k8
Copy link
Contributor Author

sago2k8 commented Jul 4, 2023

Great @toddbaert, lemme know if there is an issue I could help with to get the SDK to version 1.0.

Thank you.

@toddbaert
Copy link
Member

Great @toddbaert, lemme know if there is an issue I could help with to get the SDK to version 1.0.

Thank you.

This one certainly helps!

At the moment, the biggest hurdle for a 1.0 release is validating the static/dynamic context paradigm outlined here, which the web-sdk already adheres to. Your experience using the web SDK itself is probably valuable in itself.

@toddbaert
Copy link
Member

This is resolved with #418.

It will be released when https://github.com/open-feature/js-sdk-contrib/pull/467is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants