fix: add Provider Not Ready Error #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
beeme1mr
approved these changes
Nov 22, 2023
|
Oh, thanks for finding this @Billlynch . This should indeed be here, see https://openfeature.dev/specification/types#error-code |
toddbaert
approved these changes
Nov 22, 2023
|
I'm ready to merge, but could you sign off your commit? (it's a CNCF requirement). EDIT: I signed off this commit. |
toddbaert
force-pushed
the
add_provider_not_ready_error
branch
from
fd6c9fb
to
0bcf61d
Compare
Signed-off-by: Todd Baert <[email protected]>
This was referenced Nov 22, 2023
toddbaert
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.20](core-v0.0.19...core-v0.0.20) (2023-11-27) ### 🐛 Bug Fixes * add Provider Not Ready Error ([#680](#680)) ([b0054f9](b0054f9)) * rm NodeJS type from core, rm react core peer ([#681](#681)) ([09ff7b4](09ff7b4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <[email protected]> Signed-off-by: openfeature-peer-update-bot <[email protected]> Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert
pushed a commit
that referenced
this pull request
Nov 27, 2023
🤖 I have created a release *beep* *boop* --- ## [1.7.4](server-sdk-v1.7.3...server-sdk-v1.7.4) (2023-11-27) ### 🐛 Bug Fixes * add Provider Not Ready Error ([#680](#680)) ([b0054f9](b0054f9)) ### 🧹 Chore * **main:** release core 0.0.20 ([#682](#682)) ([9629578](9629578)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <[email protected]>
This was referenced Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Adds an Error class for the error code Provider Not Ready. To match the other error codes.