Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lower compilation target to es2015 #957

Conversation

beeme1mr
Copy link
Member

This PR

  • replace the es2022 error cause with a custom implementation
  • lower compilation target from es2022 to es2015

Related Issues

Fixes #956

Notes

The tests pass, but I still want to manually build and test the outputs in a real application to ensure everything works as expected.

Copy link
Contributor

@weyert weyert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I think its a reasonable change to have

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@beeme1mr beeme1mr added this pull request to the merge queue Jun 11, 2024
Merged via the queue into main with commit c2d6c17 Jun 11, 2024
8 checks passed
@beeme1mr beeme1mr deleted the 956-feature-consider-alternative-implementations-for-cause-in-erroroptions-to-maintain-lower-compilation-target-compatibility branch June 11, 2024 12:49
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.3.0](core-v1.2.0...core-v1.3.0)
(2024-06-11)


### ✨ New Features

* lower compilation target to es2015
([#957](#957))
([c2d6c17](c2d6c17))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: openfeature-peer-update-bot <[email protected]>
Co-authored-by: openfeature-peer-update-bot <[email protected]>
toddbaert pushed a commit that referenced this pull request Jun 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.15.0](server-sdk-v1.14.0...server-sdk-v1.15.0)
(2024-06-11)


### ✨ New Features

* lower compilation target to es2015
([#957](#957))
([c2d6c17](c2d6c17))


### 🧹 Chore

* **main:** release core 1.3.0
([#958](#958))
([25086c5](25086c5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert added a commit that referenced this pull request Jun 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[1.2.0](web-sdk-v1.1.0...web-sdk-v1.2.0)
(2024-06-11)


### ✨ New Features

* lower compilation target to es2015
([#957](#957))
([c2d6c17](c2d6c17))


### 🧹 Chore

* **main:** release core 1.3.0
([#958](#958))
([25086c5](25086c5))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
toddbaert pushed a commit that referenced this pull request Jun 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.2.1-experimental](nestjs-sdk-v0.2.0-experimental...nestjs-sdk-v0.2.1-experimental)
(2024-06-11)


### ✨ New Features

* lower compilation target to es2015
([#957](#957))
([c2d6c17](c2d6c17))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
toddbaert added a commit that referenced this pull request Jun 11, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.4.1](react-sdk-v0.4.0...react-sdk-v0.4.1)
(2024-06-11)


### ✨ New Features

* lower compilation target to es2015
([#957](#957))
([c2d6c17](c2d6c17))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Signed-off-by: OpenFeature Bot <[email protected]>
Signed-off-by: Todd Baert <[email protected]>
Co-authored-by: Todd Baert <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants