Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Outdated pinned peerDependency from web-sdk to core #963

Closed
andreas-karlsson opened this issue Jun 12, 2024 · 1 comment · Fixed by #964
Closed

[BUG] Outdated pinned peerDependency from web-sdk to core #963

andreas-karlsson opened this issue Jun 12, 2024 · 1 comment · Fixed by #964
Assignees
Labels
bug Something isn't working

Comments

@andreas-karlsson
Copy link

Observed behavior

The web-sdk has been released with "lower compilation target to es2015", but the peer dependency to core is still pinned to 1.2.0 which has compilation target es2022. Was it supposed to be updated? Should the peer dependency to core maybe use caret? Technically in semantic versioning, updating a peer dependency is a breaking change. If a caret range is used instead, I would also suggest that the devDependency is pinned to the lowest version of that range. This way it will be obvious during development if there is a need to bump the peer dependency.

Expected Behavior

No response

Steps to reproduce

No response

@andreas-karlsson andreas-karlsson added the bug Something isn't working label Jun 12, 2024
@beeme1mr beeme1mr self-assigned this Jun 12, 2024
@toddbaert
Copy link
Member

toddbaert commented Jun 12, 2024

We have automation that is supposed to catch exactly this issue, but I think either something went wrong and the CI didn't block me (perhaps because github was slow) or I overrode it. I can see where this check failed and the release PR was merged anyway 😢

@beeme1mr beeme1mr linked a pull request Jun 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants