Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Support DaViT #1105

Merged
merged 9 commits into from
Nov 16, 2022
Merged

[Feature] Support DaViT #1105

merged 9 commits into from
Nov 16, 2022

Conversation

okotaku
Copy link
Collaborator

@okotaku okotaku commented Oct 19, 2022

Motivation

paper: https://arxiv.org/abs/2204.03645
code: https://github.com/dingmyu/davit

#1096

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 0.02% // Head: 91.17% // Increases project coverage by +91.15% 🎉

Coverage data is based on head (3a246f2) compared to base (b8b31e9).
Patch has no changes to coverable lines.

❗ Current head 3a246f2 differs from pull request most recent head 8616e5f. Consider uploading reports for the commit 8616e5f to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1105       +/-   ##
============================================
+ Coverage     0.02%   91.17%   +91.15%     
============================================
  Files          121      131       +10     
  Lines         8217    10055     +1838     
  Branches      1368     1574      +206     
============================================
+ Hits             2     9168     +9166     
+ Misses        8215      675     -7540     
- Partials         0      212      +212     
Flag Coverage Δ
unittests 91.17% <ø> (+91.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/inference.py 0.00% <0.00%> (ø)
mmcls/datasets/transforms/compose.py
mmcls/models/backbones/efficientformer.py 95.08% <0.00%> (ø)
mmcls/models/backbones/mvit.py 92.46% <0.00%> (ø)
mmcls/models/backbones/deit3.py 94.52% <0.00%> (ø)
mmcls/models/backbones/mobileone.py 94.47% <0.00%> (ø)
mmcls/models/backbones/swin_transformer_v2.py 89.47% <0.00%> (ø)
mmcls/models/utils/layer_scale.py 86.66% <0.00%> (ø)
mmcls/models/heads/efficientformer_head.py 93.10% <0.00%> (ø)
mmcls/structures/utils.py 77.77% <0.00%> (ø)
... and 121 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@okotaku okotaku changed the title [WIP] Support DaViT [Feature] Support DaViT Oct 19, 2022
@Ezra-Yu Ezra-Yu self-requested a review October 28, 2022 09:21
@mzr1996 mzr1996 merged commit c4f3883 into open-mmlab:dev-1.x Nov 16, 2022
mzr1996 added a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
* add davit

* fix mixup config

* convert scripts

* lint

* test

* test

* Add checkpoint links.

Co-authored-by: mzr1996 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants