Update to allow DDR4-SORDIMM modules to be used. [2/2]

Add support for the module type in the SPD parser. This change has been tested with the VR9FR2G7228JBKSBD4 module from Viking Technologies: 2666MHz DDR4-SORDIMM, rank 2, 16GB Note - Above mentioned module need an additional patch due to an unexpected SPD manufacturer being detected. Change-Id: Ifaa98c57560ada46519bfaeb3c438795c00eb52b Signed-off-by: Evan Lojewski <[email protected]> Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70708 Tested-by: Jenkins Server <[email protected]> Tested-by: Jenkins OP Build CI <[email protected]> Tested-by: Jenkins OP HW <[email protected]> Tested-by: FSP CI Jenkins <[email protected]> Reviewed-by: Daniel M. Crowell <[email protected]>
open-power · Jan 23, 2019 · 6cb1702 · 6cb1702
1 parent 7194136
commit 6cb1702
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/usr/vpd/spd.C b/src/usr/vpd/spd.C
@@ -6,6 +6,7 @@
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
 /* Contributors Listed Below - COPYRIGHT 2013,2019                        */
+/* [+] Evan Lojewski                                                      */
 /* [+] Google Inc.                                                        */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
@@ -2014,12 +2015,16 @@ errlHndl_t getModType ( modSpecTypes_t & o_modType,
         }
         else if (SPD_DDR4_TYPE == i_memType)
         {
-            if ((MOD_TYPE_DDR4_UDIMM == modTypeVal) ||
-                (MOD_TYPE_DDR4_SO_DIMM == modTypeVal))
+            if ((MOD_TYPE_DDR4_UDIMM == modTypeVal)      ||
+                (MOD_TYPE_DDR4_SO_DIMM == modTypeVal)    ||
+                (MOD_TYPE_DDR4_MINI_UDIMM == modTypeVal) ||
+                (MOD_TYPE_DDR4_SO_UDIMM == modTypeVal))
             {
                 o_modType = UMM;
             }
-            else if (MOD_TYPE_DDR4_RDIMM == modTypeVal)
+            else if ((MOD_TYPE_DDR4_RDIMM == modTypeVal)      ||
+                     (MOD_TYPE_DDR4_MINI_RDIMM == modTypeVal) ||
+                     (MOD_TYPE_DDR4_SO_RDIMM == modTypeVal))
             {
                 o_modType = RMM;
             }

diff --git a/src/usr/vpd/spd.H b/src/usr/vpd/spd.H
@@ -6,6 +6,7 @@
 /* OpenPOWER HostBoot Project                                             */
 /*                                                                        */
 /* Contributors Listed Below - COPYRIGHT 2013,2019                        */
+/* [+] Evan Lojewski                                                      */
 /* [+] International Business Machines Corp.                              */
 /*                                                                        */
 /*                                                                        */
@@ -77,6 +78,10 @@ enum
     MOD_TYPE_DDR4_UDIMM      = 0x02,
     MOD_TYPE_DDR4_SO_DIMM    = 0x03,
     MOD_TYPE_DDR4_LRDIMM     = 0x04,
+    MOD_TYPE_DDR4_MINI_RDIMM = 0x05,
+    MOD_TYPE_DDR4_MINI_UDIMM = 0x06,
+    MOD_TYPE_DDR4_SO_RDIMM   = 0x08,
+    MOD_TYPE_DDR4_SO_UDIMM   = 0x09,
 
     DIMM_SPD_SECTION_SIZE = 0x200,  // Size each DIMM SPD section
     DIMM_SPD_MAX_SECTIONS = 512,    // Maximum number of sections