Skip to content

Commit

Permalink
PM Malf Func: Fixed bugs pertaining pm malfunction FFDC and parser.
Browse files Browse the repository at this point in the history
Fixed following:
    - printing of 64 bit register value.
    - collection 64 bit FFDC register.
Key_Cronus_Test=PM_REGRESS

CQ: SW454621
Change-Id: I4f09f635b0232bffc4cefd368f1f004569c5ef83
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70017
Tested-by: FSP CI Jenkins <[email protected]>
Tested-by: Jenkins Server <[email protected]>
Reviewed-by: RANGANATHPRASAD G. BRAHMASAMUDRA <[email protected]>
Tested-by: HWSV CI <[email protected]>
Tested-by: Cronus HW CI <[email protected]>
Tested-by: Hostboot CI <[email protected]>
Reviewed-by: Gregory S. Still <[email protected]>
Reviewed-by: Jennifer A. Stofer <[email protected]>
Reviewed-on: http://rchgit01.rchland.ibm.com/gerrit1/70018
Tested-by: Jenkins OP Build CI <[email protected]>
Tested-by: Jenkins OP HW <[email protected]>
Reviewed-by: Christian R. Geddes <[email protected]>
  • Loading branch information
premsjha authored and crgeddes committed Jan 29, 2019
1 parent 39a6b40 commit 9c147a3
Showing 1 changed file with 4 additions and 6 deletions.
10 changes: 4 additions & 6 deletions src/import/hwpf/fapi2/include/collect_reg_ffdc.H
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
/* */
/* OpenPOWER HostBoot Project */
/* */
/* Contributors Listed Below - COPYRIGHT 2015,2018 */
/* Contributors Listed Below - COPYRIGHT 2015,2019 */
/* [+] International Business Machines Corp. */
/* */
/* */
Expand Down Expand Up @@ -417,9 +417,9 @@ ReturnCode collectRegisterAndAddressData(std::vector<T>& i_addresses, U& i_reade
{
fapi2::buffer<T> l_buf;

T l_address = address + i_offset;
l_addr = address + i_offset;

l_rc = i_reader.read_register(l_address, l_buf);
l_rc = i_reader.read_register(l_addr, l_buf);

if(l_rc)
{
Expand All @@ -434,9 +434,7 @@ ReturnCode collectRegisterAndAddressData(std::vector<T>& i_addresses, U& i_reade
l_data = l_buf();
}

l_address = htobe64(l_address);
l_data = htobe64(l_data);
l_addr = l_address >> 32;
l_data = htobe64(l_data);

memcpy(o_pData, &l_addr, sizeof(uint32_t));
o_pData += sizeof(uint32_t);
Expand Down

0 comments on commit 9c147a3

Please sign in to comment.