Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
core/lock: don't set bust_locks on lock error
[ Upstream commit 5272867 ] bust_locks is a big hammer that guarantees a mess if it's set while all other threads are not stopped. I propose removing this in the lock error paths. In debugging the previous deadlock false positive, none of the error messages printed, and the in-memory console was totally garbled due to lack of locking. I think it's generally better for debugging and system integrity to keep locks held when lock errors occur. Lock busting should be used carefully, just to allow messages to be printed out or machine to be restarted, probably when the whole system is single-threaded. Skiboot is slowly working toward that being feasible with co-operative debug APIs between firmware and host, but for the time being, difficult lock crashes are better not to corrupt everything by busting locks. Signed-off-by: Nicholas Piggin <[email protected]> Signed-off-by: Stewart Smith <[email protected]> Signed-off-by: Vasant Hegde <[email protected]>
- Loading branch information