From 857f046d3ab00ec12dcb06ddabfed6bdfe00a819 Mon Sep 17 00:00:00 2001 From: Vasant Hegde Date: Mon, 8 Apr 2019 11:35:41 +0530 Subject: [PATCH] test-ipmi-hiomap: Add read-one-byte test Add test case to read: - 1 byte - 1 block and 1 byte data Cc: Andrew Jeffery Cc: skiboot-stable@lists.ozlabs.org Signed-off-by: Vasant Hegde Reviewed-by: Andrew Jeffery Signed-off-by: Stewart Smith --- libflash/test/test-ipmi-hiomap.c | 40 ++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/libflash/test/test-ipmi-hiomap.c b/libflash/test/test-ipmi-hiomap.c index abc97779c35e..e1bc5ef382a2 100644 --- a/libflash/test/test-ipmi-hiomap.c +++ b/libflash/test/test-ipmi-hiomap.c @@ -874,6 +874,24 @@ static void test_hiomap_protocol_read_one_block(void) scenario_exit(); } +static void test_hiomap_protocol_read_one_byte(void) +{ + struct blocklevel_device *bl; + uint8_t *buf; + size_t len; + + scenario_enter(scenario_hiomap_protocol_read_one_block); + assert(!ipmi_hiomap_init(&bl)); + len = 1; + buf = calloc(1, len); + assert(buf); + assert(!bl->read(bl, 0, buf, len)); + assert(lpc_read_success(buf, len)); + free(buf); + ipmi_hiomap_exit(bl); + scenario_exit(); +} + static const struct scenario_event scenario_hiomap_protocol_read_two_blocks[] = { { .type = scenario_event_p, .p = &hiomap_ack_call, }, @@ -929,6 +947,26 @@ static void test_hiomap_protocol_read_two_blocks(void) scenario_exit(); } +static void test_hiomap_protocol_read_1block_1byte(void) +{ + struct blocklevel_device *bl; + struct ipmi_hiomap *ctx; + uint8_t *buf; + size_t len; + + scenario_enter(scenario_hiomap_protocol_read_two_blocks); + assert(!ipmi_hiomap_init(&bl)); + ctx = container_of(bl, struct ipmi_hiomap, bl); + len = (1 << ctx->block_size_shift) + 1; + buf = calloc(1, len); + assert(buf); + assert(!bl->read(bl, 0, buf, len)); + assert(lpc_read_success(buf, len)); + free(buf); + ipmi_hiomap_exit(bl); + scenario_exit(); +} + static const struct scenario_event scenario_hiomap_protocol_read_one_block_twice[] = { { .type = scenario_event_p, .p = &hiomap_ack_call, }, @@ -3112,7 +3150,9 @@ struct test_case test_cases[] = { TEST_CASE(test_hiomap_event_daemon_regained_flash_control_dirty), TEST_CASE(test_hiomap_protocol_reset_recovery), TEST_CASE(test_hiomap_protocol_read_one_block), + TEST_CASE(test_hiomap_protocol_read_one_byte), TEST_CASE(test_hiomap_protocol_read_two_blocks), + TEST_CASE(test_hiomap_protocol_read_1block_1byte), TEST_CASE(test_hiomap_protocol_read_one_block_twice), TEST_CASE(test_hiomap_protocol_event_before_read), TEST_CASE(test_hiomap_protocol_event_during_read),