Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oqs-provider debian package lists statically linked liboqs as a requirement #491

Closed
fwh-dc opened this issue Aug 23, 2024 · 3 comments · Fixed by #493
Closed

oqs-provider debian package lists statically linked liboqs as a requirement #491

fwh-dc opened this issue Aug 23, 2024 · 3 comments · Fixed by #493
Labels
bug Something isn't working

Comments

@fwh-dc
Copy link
Contributor

fwh-dc commented Aug 23, 2024

Thank you for taking the time to share your thoughts with us.

set(CPACK_DEBIAN_PACKAGE_DEPENDS "libc6, openssl (>= 3.0.0), liboqs (>= 0.8.0)")

It should not be necessary to list liboqs as a dependency when liboqs is built and linked as a static library?

@fwh-dc fwh-dc added the question No code change required label Aug 23, 2024
@baentsch baentsch added bug Something isn't working and removed question No code change required labels Aug 23, 2024
@baentsch
Copy link
Member

It should not be necessary to list liboqs as a dependency when liboqs is built and linked as a static library?

That is a correct observation in my eyes -- and thus a bug in this line. As far as I remember I added this line before diving deeper into static building (reminds me I still need to complete #367)...

Thanks for the heads-up @fwh-dc !

@fwh-dc
Copy link
Contributor Author

fwh-dc commented Aug 23, 2024

Should I make a PR for it or do you want to do it?

@baentsch
Copy link
Member

Should I make a PR for it or do you want to do it?

If you'd have time, I'd gladly review the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants