-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RFC repo #130
Comments
QQ: do we want the rfcs to be part of the specification repository as a different directory or a separate repo? |
I can help with migration but want to know which approach we want to go: separate repo vs separate directory in specification |
I suggest separate repo. |
@bogdandrutu I also don't mind transferring the repo to you (or another admin) first, if that makes the most sense with respect to the org policy not allowing non-admins to create or transfer repos. |
I think you just need to add me as Admin for your repo in order to move it. But I am trying to get an agreement from others that a separate repo is the right decision here. |
Invite sent! The question has come up a few times, but I haven't heard anyone actually suggest that the RFCs should be in the spec repo. Some (definitely forgetting some! only halfway through my coffee...) advantages I see of keeping it separate:
Frankly, I've seen a high correlation (which is not to say causation!) between RFC process success and keeping the RFCs independent of the specs and other repos. |
Argh, since the repo is only owned by an individual rather an org, I can't actually make you an admin. See #131 🤷♀️ |
I can clone and move, or we can create a clean repo and you do move all the commits. |
Worked around it by transferring the repo to the LightStep org in order to make an admin. |
great! Let's do it. I'd suggest to start with empty submit docs as a PRs. It will give a chance to comment |
@SergeyKanzhelev what do you mean by "empty submit docs"? |
I meant start with empty repo and submit docs as PRs. |
Docs looks ok in general though. So just want to make sure there is a forum for discussion and commenting |
Misc: while it's on my mind, I just wanted to drop in a quick (enthusiastic) note regarding the idea of the RFC repo in general: it seems nearly impossible to have a substantive debate about "big" GitHub issues that make several substantial points "in parallel"... everything gets lost in |
@bhs nobody in this thread disagrees with the benefit of having a RFC process, the only question that I had was if this should be part of the specification or a separate repo. The second question that came during this discussion is about the process of transferring a repo with new work (like this) vs constructing it in the org. More explicitly in the current case should we create a new repo and @iredelmeier will create a PR that copies the content from the previous repo or we do a move. |
🆒, that is good to hear! |
@bhs can you try to answer some of my questions? I talked with @SergeyKanzhelev and seems to want a separate repo as well as @iredelmeier. So I am fine with this but I want to hear your opinion as well. Also will be good to have your thoughts on the second question - @SergeyKanzhelev mentioned the path to create a clean repo and do a PR that copies the code. What do you think about this? |
I am trying to not block this, but find the right path forward. |
I do not have a strong opinion about this. If it was literally up to me, I would put the RFCs into the https://github.com/open-telemetry/opentelemetry-specification repo (in a
I do not understand the details of how CLAs work with things like these. For the particular case of the RFCs, I would probably vote to have @iredelmeier create a PR that copies the (relatively small amount of) content over in one fell swoop, but I would have a different opinion about transferring a repo that had years worth of commit/PR history in it. This is not a strongly-held opinion of mine and should be considered "non-blocking."
Totally! And a worthwhile (and appreciated) thing to do given that we'll all be living this for a long time to come. |
@bhs my understanding is that @SergeyKanzhelev's concern here isn't about the CLA, but about reviewing all the changes as an addition vs suggesting changes on top of the base. @SergeyKanzhelev is that accurate? |
Can we please migrate the RFC repository (originally proposed in #56) so that we can start using it, now that the first spec milestone is finished?
An admin setting is currently blocking me from requesting that the repo be transferred.
The text was updated successfully, but these errors were encountered: