Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Changelog should compare to common ancestor #12149

Closed
djaglowski opened this issue Jul 7, 2022 · 1 comment · Fixed by #12151
Closed

[CI] Changelog should compare to common ancestor #12149

djaglowski opened this issue Jul 7, 2022 · 1 comment · Fixed by #12151
Assignees
Labels
bug Something isn't working

Comments

@djaglowski
Copy link
Member

Similar issue to #11442.

See #12124(comment)

@djaglowski djaglowski added the bug Something isn't working label Jul 7, 2022
@djaglowski djaglowski self-assigned this Jul 7, 2022
@djaglowski
Copy link
Member Author

I was able to reproduce the issue locally by running the check commands against a branch that was created prior to the CHANGELOG.md being updated on main.

➜  opentelemetry-collector-contrib (untangle-file-attributes) git fetch origin main --depth=1
remote: Total 0 (delta 0), reused 0 (delta 0), pack-reused 0
From https://github.com/open-telemetry/opentelemetry-collector-contrib
 * branch                  main       -> FETCH_HEAD
➜  opentelemetry-collector-contrib (untangle-file-attributes) git diff --name-only FETCH_HEAD                        
CHANGELOG.md
CONTRIBUTING.md
cmd/configschema/go.mod
cmd/configschema/go.sum
cmd/mdatagen/go.mod
cmd/mdatagen/go.sum
exporter/alibabacloudlogserviceexporter/go.mod
exporter/alibabacloudlogserviceexporter/go.sum
...
➜  opentelemetry-collector-contrib (untangle-file-attributes) git diff --name-only $(git merge-base origin/main HEAD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant