Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/telemetryquerylanguage] Concat factory should log when passed unprintable values #13390

Closed
evan-bradley opened this issue Aug 16, 2022 · 4 comments
Assignees
Labels
bug Something isn't working pkg/ottl priority:p2 Medium Stale

Comments

@evan-bradley
Copy link
Contributor

evan-bradley commented Aug 16, 2022

Describe the bug
The Concat factory function added in #13120 does not log if non-printable values are passed to it.

Steps to reproduce
Pass a map or an array to the Concat factory function. Nothing is inserted into the resulting string, but the user is not notified.

What did you expect to see?
A log message should be printed informing the user that one of the values they passed is not printable, to ensure they are aware of it and can fix the problem.

Additional context
Relates to #12649.

@evan-bradley evan-bradley added the bug Something isn't working label Aug 16, 2022
@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed pkg/ottl priority:p2 Medium labels Aug 16, 2022
@evan-bradley evan-bradley changed the title [pkg/telemetryquerylanguage] Concat factory should log when passed unprintable values [pkg/telemetryquerylanguage] Join factory should log when passed unprintable values Aug 17, 2022
@evan-bradley
Copy link
Contributor Author

I can take this issue.

@evan-bradley evan-bradley removed the help wanted Extra attention is needed label Oct 7, 2022
@evan-bradley evan-bradley self-assigned this Oct 7, 2022
@evan-bradley evan-bradley changed the title [pkg/telemetryquerylanguage] Join factory should log when passed unprintable values [pkg/telemetryquerylanguage] Concat factory should log when passed unprintable values Oct 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 6, 2023
@evan-bradley
Copy link
Contributor Author

Solved as part of #16519.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pkg/ottl priority:p2 Medium Stale
Projects
None yet
2 participants