Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to set Loki tenant id from resource attributes #14706

Closed
thmshmm opened this issue Oct 4, 2022 · 3 comments · Fixed by #14930 or #15285
Closed

Possibility to set Loki tenant id from resource attributes #14706

thmshmm opened this issue Oct 4, 2022 · 3 comments · Fixed by #14930 or #15285
Assignees
Labels
enhancement New feature or request exporter/loki Loki Exporter priority:p2 Medium

Comments

@thmshmm
Copy link
Contributor

thmshmm commented Oct 4, 2022

Describe the issue you're reporting

Currently the Loki exporter supports setting a dynamic tenant id based on a resource attribute using the tenant field. This field is deprecated and will be removed in v0.61.

The suggested alternative to use the "headers_setter" does not support resource attributes.

As proposed by @jpkrohling on Slack, something like a "loki.attributes.tenant" label could be introduced using a processor which can be picked up by the exporter to be set as tenant in the header.

@thmshmm thmshmm added the needs triage New item requiring triage label Oct 4, 2022
@jpkrohling
Copy link
Member

@kovrus volunteered to work on this one.

@jpkrohling jpkrohling added exporter/loki Loki Exporter and removed needs triage New item requiring triage labels Oct 4, 2022
@jpkrohling
Copy link
Member

Issue #12873 mentions the tenant header, and I think I like the name I proposed there better than what I added as a comment via Slack: loki.tenant. We could look it up first in the resource attributes, falling back to record attributes.

@kovrus
Copy link
Member

kovrus commented Oct 19, 2022

It should be closed after merging #15285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment