Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/loki] add support for logfmt #15351

Closed
domasx2 opened this issue Oct 20, 2022 · 3 comments
Closed

[exporter/loki] add support for logfmt #15351

domasx2 opened this issue Oct 20, 2022 · 3 comments
Assignees
Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana enhancement New feature or request exporter/loki Loki Exporter translator/loki

Comments

@domasx2
Copy link
Contributor

domasx2 commented Oct 20, 2022

Is your feature request related to a problem? Please describe.

I have a use case for sending logfmt-formatted log records through the otelcol to Loki. But loki exporter encodes them in JSON, ending up with { "Body": "{{message}}" }. This requires workarounds down the line to unwrap the JSON.
It would be great to have direct logfmt support for the Loki exporter.

Describe the solution you'd like

Add a loki.format attribute hint, that, if provided with value logfmt, will cause exporter to format logs using logfmt instead of JSON.

Describe alternatives you've considered

No response

Additional context

No response

@domasx2 domasx2 added enhancement New feature or request needs triage New item requiring triage labels Oct 20, 2022
@jpkrohling jpkrohling added comp:grafanalabs Grafana Labs components - Loki, Grafana exporter/loki Loki Exporter translator/loki and removed needs triage New item requiring triage labels Oct 20, 2022
@github-actions
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

@domasx2, is this still relevant? I remember you mentioning that you might not even use logfmt after all.

@domasx2
Copy link
Contributor Author

domasx2 commented Jan 25, 2023

This is implemented: #15286 my bad, should have closed the issue

@domasx2 domasx2 closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:grafanalabs Grafana Labs components - Loki, Grafana enhancement New feature or request exporter/loki Loki Exporter translator/loki
Projects
None yet
Development

No branches or pull requests

3 participants