Clickhouse - Use std batch api to insert data

[StarpTech]

Component(s)

exporter/clickhouse

Is your feature request related to a problem? Please describe.

Hi, according to https://github.com/StarpTech/opentelemetry-collector-contrib/blob/feat/improve_clickhouse_conn_mgmnt/exporter/clickhouseexporter/exporter_logs.go#L94 we issue a request per log / trace. Is there any reason for that? This must be very inefficient. We can improve it by switching to https://github.com/ClickHouse/clickhouse-go/blob/main/examples/std/batch.go

begin->prepare->(in loop exec)->commit

Describe the solution you'd like

Use prepared statement https://github.com/ClickHouse/clickhouse-go/blob/main/examples/std/batch.go

Describe alternatives you've considered

No response

Additional context

No response

[github-actions]

Pinging code owners:

• exporter/clickhouse: @hanjm @dmitryax @Frapschen

See Adding Labels via Comments if you do not have permissions to add labels yourself.

[hanjm]

we issue a request per log / trace.

no, when use batch processor, exporter will do batch insert.

opentelemetry-collector-contrib/exporter/clickhouseexporter/README.md

Lines 17 to 20 in 650e624

	Note:
	Always
	add [batch-processor](https://github.com/open-telemetry/opentelemetry-collector/tree/main/processor/batchprocessor) to
	collector pipeline,

opentelemetry-collector-contrib/CONTRIBUTING.md

Lines 154 to 159 in 650e624

	## General Recommendations
	Below are some recommendations that apply to typical components. These are not rigid rules and there are exceptions but
	in general try to follow them.
	- Avoid introducing batching, retries or worker pools directly on receivers and exporters. Typically, these are general
	cases that can be better handled via processors (that also can be reused by other receivers and exporters).

[StarpTech]

How does it work? Isn't ExecContext synchronous per entry?

[hanjm]

clickhouse-go driver do that, when start a tx, statement. ExecContext only do insert at commit.

https://github.com/ClickHouse/clickhouse-go/blob/b2f9409ba1c7bb239a4f6553a6da347f3f5f1330/clickhouse_std.go#L280-L294

https://github.com/ClickHouse/clickhouse-go/blob/b2f9409ba1c7bb239a4f6553a6da347f3f5f1330/clickhouse_std.go#L314-L332

https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/650e62407f750c349bcb9c0419732dc6135528ea/exporter/clickhouseexporter/exporter_logs.go#L239C6-L251

[StarpTech]

@hanjm great, thanks for clarifying.