Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider reducing the Go API exposed by sumologicexporter #24843

Closed
atoulme opened this issue Aug 3, 2023 · 4 comments
Closed

Consider reducing the Go API exposed by sumologicexporter #24843

atoulme opened this issue Aug 3, 2023 · 4 comments

Comments

@atoulme
Copy link
Contributor

atoulme commented Aug 3, 2023

Component(s)

exporter/sumologic

Describe the issue you're reporting

The sumologicexporter exposes a few additional elements in its Go API:

{
  "values": [
    "Carbon2Format",
    "DefaultClient",
    "DefaultCompress",
    "DefaultCompressEncoding",
    "DefaultGraphiteTemplate",
    "DefaultLogFormat",
    "DefaultMaxRequestBodySize",
    "DefaultMetricFormat",
    "DefaultSourceCategory",
    "DefaultSourceHost",
    "DefaultSourceName",
    "DeflateCompression",
    "GZIPCompression",
    "GraphiteFormat",
    "JSONFormat",
    "LogsPipeline",
    "MetricsPipeline",
    "NoCompression",
    "PrometheusFormat",
    "TextFormat"
  ],
  "structs": [
    "CompressEncodingType",
    "Config",
    "LogFormatType",
    "MetricFormatType",
    "PipelineType"
  ],
  "functions": [
    {
      "name": "CreateDefaultHTTPClientSettings",
      "receiver": "",
      "return_types": [
        "confighttp.HTTPClientSettings"
      ]
    },
    {
      "name": "LogRecordsToLogs",
      "receiver": "",
      "return_types": [
        "plog.Logs"
      ],
      "param_types": [
        "[]plog.LogRecord"
      ]
    },
    {
      "name": "NewFactory",
      "receiver": "",
      "return_types": [
        "exporter.Factory"
      ]
    }
  ]
}

Are any of those members a good target to be unexported?

@atoulme atoulme added the needs triage New item requiring triage label Aug 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@sumo-drosiek
Copy link
Member

There is no need to export them, as we do not intent to use them outside of the exporter except NewFactory

Copy link
Contributor

github-actions bot commented Nov 6, 2023

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 6, 2023
Copy link
Contributor

github-actions bot commented Jan 5, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants