Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new calls to adopt status reporting for the prometheus receiver #27605

Closed
jaronoff97 opened this issue Oct 10, 2023 · 5 comments
Closed

Add new calls to adopt status reporting for the prometheus receiver #27605

jaronoff97 opened this issue Oct 10, 2023 · 5 comments
Labels
closed as inactive enhancement New feature or request help wanted Extra attention is needed priority:p2 Medium receiver/prometheus Prometheus receiver Stale

Comments

@jaronoff97
Copy link
Contributor

Component(s)

receiver/prometheus

Is your feature request related to a problem? Please describe.

With the merging of open-telemetry/opentelemetry-collector#8169, we should begin moving over some components to start reporting. The prometheus receiver is very widely used and would be a great first candidate.

Describe the solution you'd like

Adhere to the ComponentStatus interface.

Describe alternatives you've considered

n/a

Additional context

I can take this on :)

@jaronoff97 jaronoff97 added enhancement New feature or request needs triage New item requiring triage labels Oct 10, 2023
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label Oct 10, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@bryan-aguilar bryan-aguilar added help wanted Extra attention is needed priority:p2 Medium and removed needs triage New item requiring triage labels Oct 13, 2023
Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 12, 2023
@arjunmahishi
Copy link
Contributor

arjunmahishi commented Feb 6, 2024

I was looking around to see if there are any issues I can pickup. Is this still relevant?

Looks like some things have changed since this issue was created.

  1. Component Status Reporting opentelemetry-collector#8169 introduces ReportComponentStatus. This seems to be deprecated in favor of ReportStatus.
  2. I see ReportStatus being used in prometheusreceiver (in 2 places). Are there more statuses to be reported?
    r.settings.TelemetrySettings.ReportStatus(component.NewFatalErrorEvent(err))

@jaronoff97 @bryan-aguilar

@github-actions github-actions bot removed the Stale label Feb 7, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive enhancement New feature or request help wanted Extra attention is needed priority:p2 Medium receiver/prometheus Prometheus receiver Stale
Projects
None yet
Development

No branches or pull requests

3 participants