Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Opentelemetry Processor request or suggestion #28875

Closed
kaarthick82 opened this issue Nov 3, 2023 · 13 comments
Closed

New Opentelemetry Processor request or suggestion #28875

kaarthick82 opened this issue Nov 3, 2023 · 13 comments
Labels
closed as inactive processor/tailsampling Tail sampling processor question Further information is requested Stale

Comments

@kaarthick82
Copy link

Component(s)

processor/attributes

Is your feature request related to a problem? Please describe.

Hello,
We are looking for a processor to verify some attributes in the trace event and compare with other spans of the same trace then insert a new attribute in the trace events.
Currently using "attributes" processor to insert some field. However there should be an option to add some condition to get attribute value from one trace event and the extracted attribute value should be compared / validated against other span in the same trace ( to compare the value in the event which has same trace id).

Do we have possibilities to add condition which can extract the dynamic value of an attribute from a trace/span and compare the value in the other span to insert new attributes based on the result.

Please let me know if any clarifications.

Thank you.
K Karthick

Describe the solution you'd like

extend the attributes processor to create conditions, to compare the event attributes.

Describe alternatives you've considered

No response

Additional context

No response

@kaarthick82 kaarthick82 added enhancement New feature or request needs triage New item requiring triage labels Nov 3, 2023
@github-actions github-actions bot added the processor/attributes Attributes processor label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Pinging code owners for processor/transform: @TylerHelmuth @kentquirk @bogdandrutu @evan-bradley. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Hello @kaarthick82, I believe the transform processor may be able to accomplish this. I'm not sure if it's able to compare attribute values across spans within the same trace, but I'll defer to the code owners who have more information here.

@TylerHelmuth
Copy link
Member

The transform processor is Stateless, which means it cannot be made to remember information between events. I do not believe there is a processor in Contrib to do what you're requesting. The closest component would be the Tail Sampling processor.

@kaarthick82
Copy link
Author

@TylerHelmuth Thank you for your guidance. I will take this up with Tail sampling processor.

@crobert-1 crobert-1 added question Further information is requested processor/tailsampling Tail sampling processor and removed enhancement New feature or request processor/attributes Attributes processor processor/transform Transform processor needs triage New item requiring triage labels Nov 14, 2023
Copy link
Contributor

Pinging code owners for processor/tailsampling: @jpkrohling. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@jpkrohling
Copy link
Member

If I'm understanding this correctly, the tail-sampling processor can't do this either. If OTTL had a way to run queries within a specific batch, you could use the groupbytrace processor, followed by the transform processor.

Would you mind giving us a concrete example of what you are trying to accomplish? Perhaps we can think of another solution?

@kaarthick82
Copy link
Author

kaarthick82 commented Dec 6, 2023

Hi @jpkrohling , sorry for the delay.
There are two events (IN and OUT) with same trace id and different span ids are fired to collector with max of 30 min delay. The requirement is to group these two as a single event and define a new "Status" field to be created using processors when there second event is occurred (IN and OUT)
If the second event (OUT) doesn't come in the given time range (30mins) , Error status needs to be defined in thee status field.

Copy link
Contributor

github-actions bot commented Feb 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Feb 5, 2024
@crobert-1 crobert-1 removed the Stale label Feb 5, 2024
Copy link
Contributor

github-actions bot commented Apr 8, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Apr 8, 2024
@crobert-1 crobert-1 removed the Stale label Apr 8, 2024
@jpkrohling
Copy link
Member

I think this is such a custom behavior that it would make sense to build your own processor and get it on a custom collector distribution.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 1, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive processor/tailsampling Tail sampling processor question Further information is requested Stale
Projects
None yet
Development

No branches or pull requests

4 participants