Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datadogreceiver produces incorrect telemetry.sdk.language #29458

Closed
povilasv opened this issue Nov 23, 2023 · 2 comments
Closed

datadogreceiver produces incorrect telemetry.sdk.language #29458

povilasv opened this issue Nov 23, 2023 · 2 comments
Labels
bug Something isn't working needs triage New item requiring triage receiver/couchdb

Comments

@povilasv
Copy link
Contributor

povilasv commented Nov 23, 2023

Component(s)

receiver/datadogreceiver

What happened?

Description

Looks like DataDog's library uses ".NET" as value instead of "dotnet" in their instrumentation:

See: https://github.com/DataDog/dd-trace-dotnet/blob/ecb5d5949f6c29dbe99a451c7a3574013cfeb1bd/tracer/src/Datadog.Trace/AgentHttpHeaderNames.cs#L76

So we need to remap ".NET" to "dotnet" to follow OTEL semantic conventions.

I've also doublechecked other variables, and they seem to map to semantic conventions correctly -> https://opentelemetry.io/docs/specs/semconv/resource/#telemetry-sdk

The only other odd language is javascript. DD uses "javascript" in their instrumentation -> https://github.com/search?q=repo%3ADataDog%2Fdd-trace-js%20Datadog-Meta-Lang&type=code

But we don't seem to have equivalent in semantic conventions?

Steps to Reproduce

Expected Result

Actual Result

Collector version

v0.89.0

Environment information

Environment

OS: (e.g., "Ubuntu 20.04")
Compiler(if manually compiled): (e.g., "go 14.2")

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@povilasv povilasv added bug Something isn't working needs triage New item requiring triage labels Nov 23, 2023
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@povilasv
Copy link
Contributor Author

uups wrongly selected receiver , sorry for the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage New item requiring triage receiver/couchdb
Projects
None yet
Development

No branches or pull requests

1 participant