Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/file] Support setting permissions on opened files #31459

Closed
sinkingpoint opened this issue Feb 27, 2024 · 5 comments
Closed

[exporter/file] Support setting permissions on opened files #31459

sinkingpoint opened this issue Feb 27, 2024 · 5 comments

Comments

@sinkingpoint
Copy link
Contributor

Component(s)

exporter/file

Is your feature request related to a problem? Please describe.

Currently, all files opened by the file exporter are opened with 0600 (https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/pkg/stanza/operator/output/file/file.go#L80). This precludes anything except the user that the collector is running on from reading the files that it outputs. I want to be able to configure that, so that we can have more finely grained permissions.

Describe the solution you'd like

I want to add a configuration option to the file exporter to allow setting the permissions bits, and the user/group of the file that the file exporter makes. This configuration should be generic enough that it can be used in other file-like exporters (see: namedpipeexporter)

Describe alternatives you've considered

No response

Additional context

No response

@sinkingpoint sinkingpoint added enhancement New feature or request needs triage New item requiring triage labels Feb 27, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

Pinging code owners for pkg/stanza: @djaglowski. See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atingchen
Copy link
Contributor

Hi,@sinkingpoin~I concur with the proposal to incorporate a configuration option into the file exporter for setting the permissions bits. Concurrently, I believe that the user/group associated with the file should be granted read-only permissions.
What you think?

Copy link
Contributor

github-actions bot commented Aug 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 5, 2024
Copy link
Contributor

github-actions bot commented Oct 4, 2024

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants