Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate failed to catch invalid value in resource processor #33486

Open
EddieEldridge opened this issue Jun 11, 2024 · 3 comments
Open

Validate failed to catch invalid value in resource processor #33486

EddieEldridge opened this issue Jun 11, 2024 · 3 comments
Labels
bug Something isn't working internal/core needs triage New item requiring triage

Comments

@EddieEldridge
Copy link
Contributor

Component(s)

internal/core

What happened?

Description

The validate flag failed to catch an invalid configuration

Steps to Reproduce

resource/attributes_add:
    attributes:
    - key: service.layer
      value: null  # Problem value
      action: upsert

Expected Result

The validate command would flag this as an illegal value

Actual Result

The Collector failed to start

Error: failed to build pipelines: failed to create "resource/attributes_add" processor, in pipeline "traces": error creating AttrProc. Either field "value", "from_attribute" or "from_context" setting must be specified for X-th action

Collector version

0.94.0

Environment information

No response

OpenTelemetry Collector configuration

resource/attributes_add:
    attributes:
    - key: service.layer
      value: null  # Problem value
      action: upsert

Log output

Error: failed to build pipelines: failed to create "resource/attributes_add" processor, in pipeline "traces": error creating AttrProc. Either field "value", "from_attribute" or "from_context" setting must be specified for X-th action

Additional context

No response

@EddieEldridge EddieEldridge added bug Something isn't working needs triage New item requiring triage labels Jun 11, 2024
Copy link
Contributor

Pinging code owners:

  • internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

  • internal/core: @open-telemetry/collector-approvers

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Aug 12, 2024
@EddieEldridge
Copy link
Contributor Author

Still relevant and still important imo. Can be quite easy to resolve a null value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal/core needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

1 participant