Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/transform] Allow specifying metric name suffix when using convert summary functions #33850

Open
h0cheung opened this issue Jul 2, 2024 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest processor/transform Transform processor

Comments

@h0cheung
Copy link
Contributor

h0cheung commented Jul 2, 2024

Component(s)

processor/transform

Is your feature request related to a problem? Please describe.

There are functions like convert_summary_count_val_to_sum and convert_summary_sum_val_to_sum, which can convert values in summary to sum and count.
However, the have some limitions:

  • the suffix added is always _sum or _count. But according to OpenTelemetry's convention, . should be used instead of _ in this case.
  • Support for quantile is missing.

Describe the solution you'd like

  1. Update function specification: convert_summary_count_val_to_sum(aggregation_temporality, is_monotonic, Optional[suffix]). The new optional parameters allow setting the suffix to add. By default, suffix is ".sum".
  2. New function: converter_summary_quantile_val_to_gauge(Optional[suffix]). The suffix defaults to ".quantile_%s", where %s will be replaced with the quantile value and the decimal point will be removed. For example, ".quantile_99", ".quantile_999" will be added.

Describe alternatives you've considered

Use a single function or component to convert summary to two sums and a gauge.

Additional context

No response

@h0cheung h0cheung added enhancement New feature or request needs triage New item requiring triage labels Jul 2, 2024
@github-actions github-actions bot added the processor/transform Transform processor label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@TylerHelmuth
Copy link
Member

As a workaround for now, a second statement can be written to change the metric name

@github-actions github-actions bot removed the Stale label Oct 12, 2024
@atoulme atoulme removed the needs triage New item requiring triage label Oct 12, 2024
@h0cheung
Copy link
Contributor Author

h0cheung commented Oct 23, 2024

As a workaround for now, a second statement can be written to change the metric name

But is I don't have the full list of metrics to be converted, I can't do it exactly.

If I change metric name by rename all metrics ends with _sum or _count, many metrics may be transformed incorrectly.

Using it along with routing processor and forward connector should work, but this will make the configuration quite more complex.

@TylerHelmuth
Copy link
Member

@evan-bradley and I are good with moving forward with this idea.

@TylerHelmuth TylerHelmuth added help wanted Extra attention is needed priority:p3 Lowest labels Nov 15, 2024
@TylerHelmuth TylerHelmuth changed the title improve summary metrics converting. [processor/transform] Allow specifying metric name suffix when using convert summary functions Nov 15, 2024
@TylerHelmuth TylerHelmuth added the good first issue Good for newcomers label Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed priority:p3 Lowest processor/transform Transform processor
Projects
None yet
Development

No branches or pull requests

3 participants