Add an option to respect filesystem locks to the filelog receiver. #34801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We rely on sys/x/unix for the locking, which will not compile on non-Unix targets. For non-Unix the locking code is just a no-op.
We defer the call to it so we can't really check exit status, and ignoring that causes lint failures.
djaglowski
approved these changes
Aug 22, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Add an option to respect filesystem locks to the filelog receiver.
When enabled otelcol will attempt to acquire a shared lock on files before reading them. If it is unable to acquire that lock it will ignore the file until the next poll cycle.
This feature is only implemented for Unix - on other platforms it is a no-op.
Link to tracking Issue: None
Testing: Manual testing was done on a laptop running macOS Sonoma 14.6.1. I verified that otelcol will not read a file that is actively locked by another process, and that it will proceed with reading once the lock is released.
Documentation: Added documentation for the filelog receiver describing this option.