Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectors/servicegraph] Add native histograms support #35460

Open
mar4uk opened this issue Sep 27, 2024 · 3 comments
Open

[connectors/servicegraph] Add native histograms support #35460

mar4uk opened this issue Sep 27, 2024 · 3 comments
Assignees
Labels

Comments

@mar4uk
Copy link
Contributor

mar4uk commented Sep 27, 2024

Component(s)

connector/servicegraph

Is your feature request related to a problem? Please describe.

Currently, the classic histogram is used for generating request duration metrics (traces_service_graph_request_server_seconds and traces_service_graph_request_client_seconds). It requires providing explicit buckets with latency_histogram_buckets configuration parameter or using default buckets [2ms, 4ms, 6ms, 8ms, 10ms, 50ms, 100ms, 200ms, 400ms, 800ms, 1s, 1400ms, 2s, 5s, 10s, 15s]

Configuration could be improved with adoption on exponential histogram

Describe the solution you'd like

Allow servicegraph connector to support exponential histograms. Configuration should allow configuring which type of histograms to use

The configuration of servicegraph connector should be changed to make it possible to configure different types of histograms. It could be similar to spanmetrics connector:

servicegraph:
   histogram:
      exponential:
          max_size: 100

Describe alternatives you've considered

No response

Additional context

No response

@mar4uk mar4uk added enhancement New feature or request needs triage New item requiring triage labels Sep 27, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@mar4uk
Copy link
Contributor Author

mar4uk commented Sep 27, 2024

I'm ready to start working on this

@atoulme atoulme removed the needs triage New item requiring triage label Oct 12, 2024
@atoulme
Copy link
Contributor

atoulme commented Oct 12, 2024

@mar4uk please go ahead. Codeowners, any comment on direction?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants