Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/azuremonitor] Add the ability to scrape more than 10 records #32165

Closed
cmergenthaler opened this issue Apr 4, 2024 · 4 comments · Fixed by #32380
Closed

[receiver/azuremonitor] Add the ability to scrape more than 10 records #32165

cmergenthaler opened this issue Apr 4, 2024 · 4 comments · Fixed by #32380
Labels

Comments

@cmergenthaler
Copy link
Contributor

cmergenthaler commented Apr 4, 2024

Component(s)

receiver/azuremonitor

Is your feature request related to a problem? Please describe.

The receiver only returns up to 10 records/dimensions of each metric. This is the default value when using the Go SDK. One might also be interested in more than these default 10 records.

Describe the solution you'd like

Add a setting to customize the top value

Describe alternatives you've considered

No response

Additional context

No response

@cmergenthaler cmergenthaler added enhancement New feature or request needs triage New item requiring triage labels Apr 4, 2024
Copy link
Contributor

github-actions bot commented Apr 4, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1
Copy link
Member

Do you mean the Top member variable of the MetricsClientListOptions struct? I see references to that struct in the receiver, but not the one linked in the description of this issue.

It makes sense to me, either way, from my limited understanding here.

@crobert-1 crobert-1 removed the needs triage New item requiring triage label Apr 4, 2024
@cmergenthaler
Copy link
Contributor Author

Do you mean the Top member variable of the MetricsClientListOptions struct? I see references to that struct in the receiver, but not the one linked in the description of this issue.

It makes sense to me, either way, from my limited understanding here.

Thanks for the link, seems like I've copied the wrong ref. Have adjusted my description!

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jun 5, 2024
@crobert-1 crobert-1 removed the Stale label Jun 5, 2024
codeboten pushed a commit that referenced this issue Jul 11, 2024
… size (#32380)

**Description:**
When having lots of different records of one dimension in the metric,
azure by default only returns 10 of them. This setting adds the
possibility to overwrite the default and specify a custom number in the
config of the receiver.

Fixes #32165

**Testing:**
Tested fetching metrics with different configs. Do we need a unit test
for this?

**Documentation:** 
Added parameter to README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants