Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposing a new attribute to identity Mongodb endpoint host(s) #32810

Closed
samiura opened this issue May 1, 2024 · 4 comments
Closed

Proposing a new attribute to identity Mongodb endpoint host(s) #32810

samiura opened this issue May 1, 2024 · 4 comments

Comments

@samiura
Copy link
Contributor

samiura commented May 1, 2024

Component(s)

receiver/mongodb

Is your feature request related to a problem? Please describe.

Currently, if we have multiple MongoDB server running on different hosts there is no way from collector's point view to count them and show the exact number of them. It can only be done in agent mode where collector is running side by side with a MongoDB server. Can we have something similar like Prometheus receiver, where it uses net.host.name for this purpose (deprecated as of now).
However, it’s changed in semconv to server.address and server.port. We can add this to the MongoDB.
https://github.com/open-telemetry/semantic-conventions/blob/651d779183ecc7c2f8cfa90bf94e105f7b9d3f5a/docs/attributes-registry/server.md

Describe the solution you'd like

Add a new attribute to extract the MongoDB server address and port. Details of the implementation is subject to discussion at this stage.

Describe alternatives you've considered

No response

Additional context

No response

@samiura samiura added enhancement New feature or request needs triage New item requiring triage labels May 1, 2024
Copy link
Contributor

github-actions bot commented May 1, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@dmitryax
Copy link
Member

dmitryax commented May 2, 2024

Sounds reasonable to me

@djaglowski djaglowski removed the needs triage New item requiring triage label May 2, 2024
dmitryax added a commit that referenced this issue Jun 25, 2024
The new attribute are added to the MongoDB receiver to distinguish
metrics coming from different MongoDB instances.
- `server.address`: The address of the MongoDB host, enabled by default.
  - `server.port`: The port of the MongoDB host, disabled by default.

Resolves
#32350
and
#32810

Co-authored-by: Curtis Robert <[email protected]>
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jul 2, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants